Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minisign@0.12: add arm64 architecture #6461

Merged

Conversation

Ra2-IFV
Copy link
Contributor

@Ra2-IFV Ra2-IFV commented Jan 16, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Sorry, something went wrong.

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

bitwarden-cli

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

minisign

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Sorry, something went wrong.

@Ra2-IFV Ra2-IFV force-pushed the feat_minisign_more-arch branch from 59a25a0 to e1098f7 Compare January 16, 2025 16:11
@Ra2-IFV Ra2-IFV changed the title Feat minisign more arch minisign: Support more arch Jan 16, 2025
@Ra2-IFV Ra2-IFV changed the title minisign: Support more arch minisign@0.12: Support more arch Jan 16, 2025
@Skycoder42
Copy link

Please merge this. The current installation of minisign fails, as the path has changed and thus the current installer fails. This would fix the issue.

  Installing 'minisign' (0.12) [64bit] from 'main' bucket
  Downloading https://github.com/jedisct1/minisign/releases/download/0.12/minisign-0.12-win64.zip (246.6 KB)...
  Checking hash of minisign-0.12-win64.zip ... ok.
  Extracting minisign-0.12-win64.zip ... done.
  Linking ~\scoop\apps\minisign\current => ~\scoop\apps\minisign\0.12
  Creating shim for 'minisign'.
  Get-Command: C:\Users\runneradmin\scoop\apps\scoop\current\lib\install.ps1:757
  Line |
   757 |              $bin = (Get-Command $target).Source
       |                      ~~~~~~~~~~~~~~~~~~~
       | The term 'minisign.exe' is not recognized as a name of a cmdlet, function, script file, or executable program.
       | Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
  Can't shim 'minisign.exe': File doesn't exist.

@goostleek
Copy link
Member

Thx for fixing this @Ra2-IFV. 👌

You have added a new architecture, please also update the autoupdate section of the manifest accordingly.

Close: ScoopInstaller#6459

Signed-off-by: Ryan Keane <the.ra2.ifv@gmail.com>
@Ra2-IFV Ra2-IFV force-pushed the feat_minisign_more-arch branch from e1098f7 to e3eb862 Compare January 30, 2025 15:43
@Ra2-IFV
Copy link
Contributor Author

Ra2-IFV commented Jan 30, 2025

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

minisign

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

Sorry, something went wrong.

@goostleek goostleek changed the title minisign@0.12: Support more arch minisign@0.12: add arm64 architecture Jan 30, 2025
@goostleek goostleek merged commit 6439af1 into ScoopInstaller:master Jan 30, 2025
2 checks passed
@Ra2-IFV Ra2-IFV deleted the feat_minisign_more-arch branch January 30, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants